Add formatDate and parseDate to typings

[no23reason]

The formatDate and parseDate are not mentioned in the typings for LocaleUtils although they contain them. This means the code in the example:

import MomentLocaleUtils, {
  formatDate,
  parseDate,
} from 'react-day-picker/moment';

ends up with an error in TypeScript. If this is merged, this code could be replaced by

import MomentLocaleUtils from 'react-day-picker/moment';
// MomentLocaleUtils contains formatDate and parseDate even in TypeScript

[codecov]

Codecov Report

Merging #873 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #873   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         659    659           
  Branches      146    146           
=====================================
  Hits          659    659

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b086617...921b376. Read the comment docs.

[codecov]

Codecov Report

Merging #873 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #873   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         659    659           
  Branches      146    146           
=====================================
  Hits          659    659

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b086617...921b376. Read the comment docs.

[codecov]

Codecov Report

Merging #873 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #873   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         659    659           
  Branches      146    146           
=====================================
  Hits          659    659

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b086617...921b376. Read the comment docs.

[codecov]

Codecov Report

Merging #873 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #873   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         659    659           
  Branches      146    146           
=====================================
  Hits          659    659

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b086617...921b376. Read the comment docs.

[lukewis]

It seems that this "worked" in v7.2.4, but broke with v7.3.0

[undrivendev]

You declared the formatDate signature as:
formatDate(date: Date, format?: string | string[], locale?: string): string;
But given that the moment.js 'string + format' method signature declares the format to be a string and not a string[], shouldn't you change it to:
formatDate(date: Date, format?: string, locale?: string): string; .
Also, the method parseDate can also return undefined, so the return type should be changed to Date | undefined .. IMO

[singingwolfboy]

formatDate and parseDate are not exported in the LocaleUtils file. They are exported in the MomentLocaleUtils file, however. I made a different pull request (#895) that reflects this situation more accurately.

[gpbl]

Is this fixed via #899?

[estephinson]

Is this fixed via #899?

I would say not, in #899 there is no change to the typings, purely refactoring, the issue is purely formatDate and parseDate are not exposed. Correct me if I'm wrong, but there is no change in #899 to include formatDate and parseDate?

[estephinson]

Current workaround for me is to simply define the functions in the project yourself, as thankfully they're relatively simple:

function formatDate(date, format = 'L', locale = 'en') {
    return moment(date)
        .locale(locale)
        .format(Array.isArray(format) ? format[0] : format);
}

function parseDate(str, format = 'L', locale = 'en') {
    const m = moment(str, format, locale, true);
    if (m.isValid()) {
        return m.toDate();
    }
    return undefined;
}