-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve typings, use TypeScript 3.1 #929
Conversation
Codecov Report
@@ Coverage Diff @@
## master #929 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 659 659
Branches 146 146
=====================================
Hits 659 659 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #929 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 659 659
Branches 146 146
=====================================
Hits 659 659 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you @adidahiya, sorry for the late merge. I'm going fast forward with version 8 which is interely in typescript. I'd love your feedback: #942
* Upgrade TypeScript to 3.1 * Remove explicit TypeScript dependency * Remove redundant type exports * Add types/README.md
noImplicitAny
in tsconfig.json so that you can check you are using types likeReact.Component
correctly@types/react
to get this to worktypes/index.d.ts
DateUtils
,LocaleUtils
, andModifiersUtils
are all alreadyconst
values inutils.d.ts
which are reexported byexport * from './utils';
, there is no need to explicitly export themreact-day-picker
submodules. This was the reason for the bug in DateTime 3.9.2 datePickerCore.d.ts 'LocaleUtils' type reference error palantir/blueprint#3703: we were importing fromreact-day-picker/types/utils
, which had a breaking change in Fix utils TypeScript types #899. I was able to fix our usage by importing from the module root: [datetime] fix: upgrade react-day-picker, clean up type imports palantir/blueprint#3725