This repository has been archived by the owner on Sep 21, 2020. It is now read-only.
Fix gcp-unit-tests #481
Merged
Fix gcp-unit-tests #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrtyler
reviewed
Aug 13, 2019
| script: | ||
| - cd shared/rakefiles/tests | ||
| - bundle install --path "vendor/bundle" | ||
| - bundle install --with test |
There was a problem hiding this comment.
Why did you drop this path? Looks like now it will try to install to a system directory, which is probably not what we want.
Also, if you'd like to change this, please update the entry in .gitignore.
There was a problem hiding this comment.
I think there are some clean rules that would need updating also.
There was a problem hiding this comment.
Yep, installing this into system directory is not going to work, because of permissions issue. Installing into vendor/bundle would not work as well, because it will try to install entire bundle from scratch and fail due to missing ruby headers. Let me revert this to not block the pipeline.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is small regression, introduced in gpii-ops/exekube#67