-
Notifications
You must be signed in to change notification settings - Fork 15
GPII-4273 #610
base: master
Are you sure you want to change the base?
GPII-4273 #610
Conversation
Merged changes from @stepanstipl 's |
generated: | ||
repository: gcr.io/gpii-common-prd/gpii__universal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep using the gpii/universal official repository instead. Is this possible @klown ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amatas
We won't be using this version of versions.yml
because my changes to gpii-universal have not been merged into master yet; and versions.yml
is using my docker image for the flowmanager
, preferences
, dataloader
, flushtokens
, and productiontests
components. When the changes have been merged into master, I will update versions.yml
to reference the gpii/universal
repository with the correct tag.
This PR is not ready to merge into gpii-infra's master branch. It's just a way of testing the changes in my dev cluster, in concert with @stepanstipl's changes to istio.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would mark this PR as "work-in-progress", but I don't have the authority to add labels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it, thanks @klown
My GPII-4273 branch of gpii-universal was updated with respect to the master branch, then the docker images rebuilt and deployed for testing in my dev cluster.
Updated the image such that it contains the latest code from gpii-universal as well as the changes for GPII-4273.
Docker image updated such that it contains the latest code from both gpii-universal master branch and the GPII-4273 branch.
Preliminary PR for testing the changes to gpii-universal for GPII-4273 in GCP.
https://issues.gpii.net/browse/GPII-4273