Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the out-node build #3160

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

kainino0x
Copy link
Collaborator

This isn't used anywhere in the CTS. All of the tools are run through ts-node which does this compilation in-memory.

However we can't land this yet because there are external things (at least, in Chrome) that use this build.
They will have to be reconfigured to use the out build.

The difference is out uses ES Modules (import), while out-node uses CommonJS (require).

Issue: None


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

This isn't actually used. All of the tools are run through ts-node which
does this compilation in-memory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant