Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GPUAdapter requestAdapterInfo() method with info attribute #3679

Merged
merged 9 commits into from
May 30, 2024

Conversation

beaufortfrancois
Copy link
Collaborator

@beaufortfrancois beaufortfrancois commented Apr 17, 2024

This PR is not meant to be merged until gpuweb/gpuweb#4662 is merged.

image

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.) It currently requires https://chromium-review.googlesource.com/c/chromium/src/+/5458182
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@beaufortfrancois beaufortfrancois marked this pull request as draft April 17, 2024 13:58
@beaufortfrancois beaufortfrancois changed the title Add GPUAdapter.info test Replace GPUAdapter requestAdapterInfo() method with info attribute May 28, 2024
@beaufortfrancois beaufortfrancois marked this pull request as ready for review May 28, 2024 07:51
@beaufortfrancois
Copy link
Collaborator Author

FYI I also need to bump WebGPU types in this PR when gpuweb/types#148 is merged and a new version is realeased.

@kainino0x kainino0x mentioned this pull request May 29, 2024
2 tasks
@kainino0x
Copy link
Collaborator

FYI I also need to bump WebGPU types in this PR when gpuweb/types#148 is merged and a new version is realeased.

More types changes were needed to make this compile:
gpuweb/types#149
And a few more CTS changes were needed so I opened a separate PR to roll the types:
#3770
Once that lands we can Update branch on this PR and it should be landable.

@kainino0x kainino0x enabled auto-merge (squash) May 30, 2024 19:55
@kainino0x kainino0x merged commit ebfde96 into main May 30, 2024
1 check passed
@kainino0x kainino0x deleted the info branch May 30, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants