-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guarantee that OOB writes to storage textures will be ignored #4194
base: main
Are you sure you want to change the base?
Conversation
We shipped the clamping behaviour on backends that need clamping. So we can't strengthen the spec in this way. |
I see that tint is indeed clamping. But as far as I found that shouldn't be necessary. Would this have to land in a v2 of the WGSL spec instead? |
@alan-baker Which backends need clamping? Teo is saying that none exist; if that's not the case, then that changes everything. |
I thought remembered reading it UB on one platform, but I can't find that text anywhere. When I look through the various specs it does seem to that writes are discarded. |
@alan-baker So, did Dawn actually ship clamping OOB texture writes on any backends, then? |
Yes. We shipped M113 with clamping on all backends. Texture write clamping was recently disabled for D3D. Based on #3893 (comment), perhaps we can do the same for other backends. We do have a GLSL backend - I haven't done my homework to determine whether OOB writes there are also automatically discarded. |
The OpenGL 4.2+ and OpenGL ES 3.1+ specs say "Invalid image stores will have no effect.". |
See #3893 (comment)