Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of GR-52454: Include signal exit handlers in the image build if JFR #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roberttoyonaga
Copy link
Contributor

I'm backporting this change so that JFR is able to dump recordings by default if apps are stopped with SIGINT. This is important because without it users must manually specify a recording duration to create dump (or wait until the program finishes on its own). Previously --install-exit-handlers had to be specified at build time to get the same behaviour.

This should be a low risk because the change only lessens the strictness of the check whether to install exist signal handlers. This only changes the default behaviour when using JFR.

Tested with mx native-unittest: passed
Also tested manually with:

mx native-image  --enable-monitoring=jfr -m jdk.httpserver
./jdk.httpserver -XX:StartFlightRecording=filename=rec.jfr 
SIGINT
jfr summary  rec.jfr

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 22, 2024
@roberttoyonaga
Copy link
Contributor Author

It seems like truffle issues are causing failures in:

  • GraalVM Gate / /compiler style,fullbuild,test JDK21
  • GraalVM Gate / /truffle JDK21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant