Use explicit encoding for reading from file. #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open() without encoding uses platform default encoding. On WIndows it can be encoding which has some bytes undefined - for example Windows-1250 don't know 0x88.
|
Hello Filip Jirsák, thanks for contributing a PR to our project! We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address filip -(at)- jirsak -(dot)- org. You can sign it at that link. If you think you've already signed it, please comment below and we'll check. |
|
Filip Jirsák has signed the Oracle Contributor Agreement (based on email address filip -(at)- jirsak -(dot)- org) so can contribute to this repository. |
dougxc
reviewed
Jun 22, 2021
| @@ -130,7 +130,7 @@ def read_core_prefs_file(self): | |||
| class FileInfo: | |||
| def __init__(self, path): | |||
| self.path = path | |||
| with open(path) as fp: | |||
| with open(path, encoding='utf-8') as fp: | |||
There was a problem hiding this comment.
This does not work on python2:
File "/b/b/e/path with a space/mx_ide_eclipse.py", line 133, in __init__
with open(path, encoding='utf-8') as fp:
TypeError: 'encoding' is an invalid keyword argument for this function
We are working to make mx require python 3.6 but are not quite there yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open() without encoding uses platform default encoding. On Windows it can be encoding that has some bytes undefined - for example, in Windows-1250 encoding there doesn't exist char with code 0x88.