-
Notifications
You must be signed in to change notification settings - Fork 51
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Do not use separate agent directories when agent is invoked on main
This is a workaround for goal execution ordering problems with Maven. For tests, we can add a synthetic goal which is executed in the same phase and will merge the agent files generated by the test execution. Unfortunately, this approach doesn't work if we want to instrument the main execution, which is sometimes the case. This is not doable because we won't have a phase to hook into and a goal to execute in order to merge the files. Even if we synthetize a goal and try to add it to the session execution, this would cause ordering issues because we don't know in which order the plugins are defined in the build file. In addition, this would simply not work for multi-module builds. As a workaround, we simply disable the split agent output directories in case we instrument the main execution. This will hopefully work for most invocations.
- Loading branch information
Showing
2 changed files
with
50 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters