Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add native configuration repository support library #201

Closed
wants to merge 2 commits into from
Closed

Add native configuration repository support library #201

wants to merge 2 commits into from

Conversation

melix
Copy link
Collaborator

@melix melix commented Feb 8, 2022

This relates to #197 by providing a support library which can be used by both the Maven and Gradle plugins.

The library assumes that the repository is available locally on the file system.

The repository can be queried this way:

Set<Path> configDirs = repository.findConfigurationDirectoriesFor("my.awesome:library:1.1")

or, with more advanced queries:

Set<Path> configDirs = repository.findConfigurationDirectoriesFor(spec -> {
    spec.useLatestConfigWhenVersionIsUntested();
    spec.forArtifacts("my.awesome.library:1.1");
    spec.forArtifact(artifact -> {
        artifact.gav("my.other:lib:1.5");
        artifact.forceConfigVersion("5");
    });
});

@melix melix added the enhancement New feature or request label Feb 8, 2022
@melix melix self-assigned this Feb 8, 2022
@melix melix force-pushed the cc/config-repository-support branch 2 times, most recently from 0e25fd2 to 40180b2 Compare February 8, 2022 11:06
@melix melix force-pushed the cc/config-repository-support branch from 40180b2 to c84287f Compare February 9, 2022 09:40
@melix melix mentioned this pull request Feb 10, 2022
Merged
@melix melix force-pushed the cc/config-repository-support branch 2 times, most recently from 244f817 to a9787d0 Compare February 28, 2022 14:35
@melix
Initial support for a configuration repository
70520f7 
This commit introduces a new module, `native-config`, which is a support
library for the GraalVM native configuration repository. It makes it
possible to use a file-system based repository which contains native
configuration directories for a set of modules.
@melix
Introduce the ability to configure queries
21cae2d 
Instead of simply querying by artifact GAV coordinates, the
configuration repository can now be queried with an advanced
query model which supports falling back to a default configuration
directory, or overriding a particular version.
@melix melix force-pushed the cc/config-repository-support branch from a9787d0 to 21cae2d Compare February 28, 2022 16:47
@melix melix marked this pull request as ready for review February 28, 2022 16:47
sdeleuze
sdeleuze reviewed Mar 15, 2022
View reviewed changes
Copy link
Collaborator

@sdeleuze sdeleuze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should this PR be adapted to take in account the new name jvm-reachability-metadata by replacing "Configuration" by "Metadata" and "Native" by "Reachability" for example?

@melix
Copy link
Collaborator Author

melix commented Mar 16, 2022

Renames have been done as part of the other PR, to avoid merge conflicts: 7df6adc

@melix
Copy link
Collaborator Author

melix commented Mar 18, 2022

Superceded by #204

@melix melix closed this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdeleuze sdeleuze sdeleuze left review comments

@graemerocher graemerocher graemerocher approved these changes

Assignees

@melix melix

Labels
enhancement New feature or request oracle-emp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@melix @graemerocher @sdeleuze @graalvmbot