Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and fix --exclude-config regression #341

Merged
merged 2 commits into from Oct 18, 2022
Merged

Test and fix --exclude-config regression #341

merged 2 commits into from Oct 18, 2022

Conversation

sdeleuze
Copy link
Collaborator

@sdeleuze sdeleuze commented Oct 17, 2022 •
edited

Can now be checked by running OfficialMetadataRepoFunctionalTest for Gradle
and OfficialMetadataRepositoryFunctionalTest for Maven.

See gh-340

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 17, 2022
@sdeleuze sdeleuze force-pushed the missing-exclude-config-repro branch 2 times, most recently from 8360029 to ecb221b Compare October 17, 2022 15:08
@sdeleuze sdeleuze requested a review from melix October 17, 2022 15:08
@sdeleuze sdeleuze marked this pull request as ready for review October 17, 2022 15:08
@sdeleuze
Copy link
Collaborator Author

OfficialMetadataRepoFunctionalTest with Gradle is broken due to #340.

@sdeleuze
Modify tests to check --exclude-config works as expected
713010f 
Can now be checked by running OfficialMetadataRepoFunctionalTest for Gradle
and OfficialMetadataRepositoryFunctionalTest for Maven.

See graalvmgh-340
@sdeleuze
Fix --exclude-config regression with Gradle
65777a7 
Closes graalvmgh-340
@sdeleuze sdeleuze changed the title Modify tests to check --exclude-config works as expected Test and fix --exclude-config regression Oct 17, 2022
@sdeleuze
Copy link
Collaborator Author

@melix The regression was caused by a3b5f3f#diff-3ca19e7e49fe64feca3a1e88279c961b56e03450666583025c711da44cfb73bbL359-L370, this PR revert those changes.

I have been able to validate it works both with NBT tests and with Spring AOT webflux-netty sample.

@sdeleuze sdeleuze requested review from dnestoro and gradinac and removed request for melix and gradinac October 17, 2022 20:03
@aclement
Copy link
Collaborator

looks good to me.

@melix melix merged commit 05aa11c into graalvm:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melix melix melix approved these changes

@dnestoro dnestoro Awaiting requested review from dnestoro

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sdeleuze @aclement @melix