Fix deadlock when collecting metadata #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reachability metadata service is not thread-safe, but it is possible for it to be called from multiple tasks in a multi-project. It this happens, then a deadlock may happen, or weird errors with a property not set can be thrown at the user. This fixes the problem by making sure only a single task can access the service concurrently. Ideally, the service should be reworked to allow concurrent access, but it's quite some work since it involves locking access to the repository (typically to download and unzip metadata). Fixes #387
oracle-contributor-agreement
bot
added
the
OCA Verified
alvarosanchez
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reachability metadata service is not thread-safe, but it is possible for it to be called from multiple tasks in a multi-project. It this happens, then a deadlock may happen, or weird errors with a property not set can be thrown at the user.
This fixes the problem by making sure only a single task can access the service concurrently. Ideally, the service should be reworked to allow concurrent access, but it's quite some work since it involves locking access to the repository (typically to download and unzip metadata).
Fixes #387