Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new write-args-file goal #408

Merged
merged 5 commits into from Mar 1, 2023
Merged

Add a new write-args-file goal #408

merged 5 commits into from Mar 1, 2023

Conversation

alvarosanchez
Copy link
Collaborator

This PR introduces a goal that only writes the args file, so that other plugins further in the lifecycle can use it. In particular, the Micronaut Maven Plugin needs this goal.

The path to the args file is stored in the MavenProject properties, an approach that is used by other plugins such as the JaCoCo Maven Plugin.

This PR introduces a goal that only writes the args file, so that other plugins further in the lifecycle can use it. In particular, the Micronaut Maven Plugin needs this goal.

The path to the args file is stored in the `MavenProject` properties, an approach that is used by other plugins such as the JaCoCo Maven Plugin.
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 28, 2023
alvarosanchez added a commit to micronaut-projects/micronaut-maven-plugin that referenced this pull request Feb 28, 2023
Copy link
Collaborator

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: this only works for the "main" arguments. Do you need something similar for test? Also, will this approach work with Micronaut AOT?

docs/src/docs/asciidoc/index.adoc Outdated Show resolved Hide resolved
@alvarosanchez
Copy link
Collaborator Author

Do you need something similar for test?

The use case is persisting the arguments that native:compile|no-fork would use to produce a native executable, so that they can be reused within Docker, for example.

will this approach work with Micronaut AOT?

It does work! 🎉
It is being tested in micronaut-projects/micronaut-maven-plugin#643 (which needs the new NBT snapshot to pass)

@alvarosanchez alvarosanchez merged commit 13f6a00 into master Mar 1, 2023
alvarosanchez added a commit to micronaut-projects/micronaut-maven-plugin that referenced this pull request Mar 7, 2023
* Fix integration with the GraalVM Metadata Repository

Blocked by graalvm/native-build-tools#408

* Fix build

* Skipping invoker tests

* Address Sonar issues, and improve the Dockerfile mojo

* Yet another Sonar issue
@melix melix added this to the 0.9.21 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants