Disable toolchain detection by default #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the changes coming in GraalVM regarding versioning, in particular the fact that the GraalVM version becomes internal and that the vendor string is changing, toolchain detection will clearly be broken for all users. This commit therefore disables toolchain detection by default, and makes sure to document properly the new behavior.
oracle-contributor-agreement
bot
added
the
OCA Verified
fniephaus
requested changes
Apr 4, 2023
Co-authored-by: Fabio Niephaus <code@fniephaus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes coming in GraalVM regarding versioning, in particular the fact that the GraalVM version becomes internal and that the vendor string is changing, toolchain detection will clearly be broken for all users.
This commit therefore disables toolchain detection by default, and makes sure to document properly the new behavior.