Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly declare dependencies for plexus-xml and plexus-utils #484

Merged
merged 1 commit into from Sep 4, 2023
Merged

Explicitly declare dependencies for plexus-xml and plexus-utils #484

merged 1 commit into from Sep 4, 2023

Conversation

linghengqian
Copy link
Contributor

@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Aug 12, 2023
@oracle-contributor-agreement
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Aug 17, 2023
@linghengqian linghengqian marked this pull request as ready for review August 17, 2023 11:38
@melix melix merged commit d6eedb6 into graalvm:master Sep 4, 2023
3 checks passed
@linghengqian linghengqian deleted the add-plexus-utils branch September 4, 2023 12:47
@dnestoro
Copy link
Collaborator

dnestoro commented Sep 4, 2023

Should this change also be documented in our changelog @melix ?

@melix
Copy link
Collaborator

melix commented Sep 4, 2023

Fair point. I think we could simply say "Fix compatibility with Maven 3.9"

@linghengqian
Copy link
Contributor Author

@linghengqian can you create a quick PR to add missing changelog note (with text @melix mentioned above)?

  • @dnestoro Looks like github.com deleted your comment, I just saw it in my email spam. Do I still need to do this?

@dnestoro
Copy link
Collaborator

dnestoro commented Sep 6, 2023

@linghengqian No, we will add that once we create a new release. Thank you anyway

@olpaw
Copy link
Member

olpaw commented Sep 6, 2023

Fair point. I think we could simply say "Fix compatibility with Maven 3.9"

Added 5cb65e5

@linghengqian linghengqian mentioned this pull request Nov 13, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosanchez alvarosanchez alvarosanchez approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native maven plugin agent not compatible with Maven 3.9.x
5 participants
@linghengqian @dnestoro @melix @olpaw @alvarosanchez