Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and improvements for GraalVM for JDK 21. #506

Merged
merged 6 commits into from Sep 13, 2023
Merged

Conversation

fniephaus
Copy link
Member

Note: We need to run with --strict-image-heap enabled on GraalVM dev builds / GraalVM for JDK 21 in the future. The current dev build does not have the option, but has --strict-image-heap enabled by default.

@fniephaus fniephaus self-assigned this Sep 12, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 12, 2023
@olpaw
Copy link
Member

olpaw commented Sep 12, 2023

AFAIU we do not want end-users to use the version of NBTs that has this change. This is just for our own testing until time is right to switch to a GraalVM native-image where --strict-image-heap is the default. Correct?

@fniephaus
Copy link
Member Author

AFAIU we do not want end-users to use the version of NBTs that has this change. This is just for our own testing until time is right to switch to a GraalVM native-image where --strict-image-heap is the default. Correct?

We want users of GraalVM for JDK 21 to adopt --strict-image-heap as soon as possible, so support for it in NBT is necessary if you ask me. On the other hand, the additional build-time init policies should still work as before without --strict-image-heap: they are just complementary policies that we didn't know were actually needed. But yes, we should probably test this to be on the safe side.

@fniephaus
Copy link
Member Author

But yes, we should probably test this to be on the safe side.

Here's one way to test this now: f7d1eb6

@olpaw
Copy link
Member

olpaw commented Sep 13, 2023

But yes, we should probably test this to be on the safe side.

Here's one way to test this now: f7d1eb6

Ok, this proves that the newly added JUnit init-at-build-/run-time configs have no side effect when --strict-image-heap is off.

Sounds safe enough for me.

@olpaw olpaw merged commit 8325440 into master Sep 13, 2023
1 check passed
@olpaw olpaw deleted the fniephaus/dev-build branch September 13, 2023 09:44
@fniephaus
Copy link
Member Author

It seems this is blocking the Micronaut Gradle plugin release: micronaut-projects/micronaut-starter#2045 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants