New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve major JDK version detection. #523

Merged

fniephaus merged 3 commits into master from fniephaus/fixes

Oct 13, 2023

Member

fniephaus commented Oct 13, 2023

No description provided.

fniephaus added 2 commits

October 13, 2023 10:29


          Upgrade to JUnit Platform 1.10.0.

c79ef2b

Fixes #492.


          Fix and improve major JDK version detection.

d96da57

Fixes #516

fniephaus requested review from melix, olpaw and dnestoro

October 13, 2023 11:27

oracle-contributor-agreement bot added the OCA Verified label

melix approved these changes

View reviewed changes

melix added this to the 0.9.28 milestone

Collaborator

melix commented Oct 13, 2023

Don't forget to add an entry to the changelog

dnestoro approved these changes

View reviewed changes


          Add changelog entry and fix changelog. [ci skip]

e45d675

Member Author

fniephaus commented Oct 13, 2023

@melix it seems we messed up one changelog entry: this one was merge two days ago and thus, the change cannot be in 0.9.27, right?

https://github.com/graalvm/native-build-tools/pull/523/files#diff-8e0193f59af80465cca40856b0c82e034b37ca6406b08b5c528ad3ce6093a200R29

Collaborator

melix commented Oct 13, 2023

We can manually fix the changelog entry by editing the file on the gh-pages branch, but for the tag it's too late, yes.

fniephaus self-assigned this

fniephaus merged commit 79ec419 into master

1 check passed

fniephaus deleted the fniephaus/fixes branch

October 13, 2023 13:29

apereocas-bot pushed a commit to apereo/cas that referenced this pull request


          renovatebot(deps): update dependency org.graalvm.buildtools:native-gr…

051c39f

…adle-plugin to v0.9.28

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.graalvm.buildtools:native-gradle-plugin](https://togithub.com/graalvm/native-build-tools) | `0.9.27` -> `0.9.28` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.graalvm.buildtools:native-gradle-plugin/0.9.28?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.graalvm.buildtools:native-gradle-plugin/0.9.28?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.graalvm.buildtools:native-gradle-plugin/0.9.27/0.9.28?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.graalvm.buildtools:native-gradle-plugin/0.9.27/0.9.28?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>graalvm/native-build-tools (org.graalvm.buildtools:native-gradle-plugin)</summary>

### [`v0.9.28`](https://togithub.com/graalvm/native-build-tools/releases/tag/0.9.28)

[Compare Source](https://togithub.com/graalvm/native-build-tools/compare/0.9.27...0.9.28)

#### What's Changed

-   Revert to previous version of `escapeArg()`. by [@&#8203;fniephaus](https://togithub.com/fniephaus) in [graalvm/native-build-tools#515
-   Document test binary configuration by [@&#8203;abelsromero](https://togithub.com/abelsromero) in [graalvm/native-build-tools#509
-   Fixes the problem that `org.junit.jupiter.api.condition.EnabledOnOs` cannot be used in NativeTest by [@&#8203;linghengqian](https://togithub.com/linghengqian) in [graalvm/native-build-tools#504
-   Remove deprecated use of `getConvention` by [@&#8203;melix](https://togithub.com/melix) in [graalvm/native-build-tools#522
-   Fix and improve major JDK version detection. by [@&#8203;fniephaus](https://togithub.com/fniephaus) in [graalvm/native-build-tools#523
-   Bump com.h2database:h2 from 2.1.210 to 2.2.220 in /samples/metadata-repo-integration by [@&#8203;dependabot](https://togithub.com/dependabot) in [graalvm/native-build-tools#499
-   Fix toolchain documentation by [@&#8203;dnestoro](https://togithub.com/dnestoro) in [graalvm/native-build-tools#525
-   Re-enable Windows builds. by [@&#8203;fniephaus](https://togithub.com/fniephaus) in [graalvm/native-build-tools#524
-   Fix h2-related tests. by [@&#8203;fniephaus](https://togithub.com/fniephaus) in [graalvm/native-build-tools#526
-   Make metadata repo test version-agnostic. by [@&#8203;fniephaus](https://togithub.com/fniephaus) in [graalvm/native-build-tools#527
-   Make metadata repo Gradle test version-agnostic. by [@&#8203;fniephaus](https://togithub.com/fniephaus) in [graalvm/native-build-tools#528

#### New Contributors

-   [@&#8203;dependabot](https://togithub.com/dependabot) made their first contribution in [graalvm/native-build-tools#499

**Full Changelog**: graalvm/native-build-tools@0.9.27...0.9.28

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,before 6am every weekday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apereo/cas).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment