Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Time Required for Each Test Execution #531

Merged
merged 2 commits into from Oct 27, 2023
Merged

Reduce Time Required for Each Test Execution #531

merged 2 commits into from Oct 27, 2023

Conversation

dnestoro
Copy link
Collaborator

@dnestoro dnestoro commented Oct 23, 2023 •
edited

This PR should update tests so that they run with -Ob flag

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 23, 2023
@dnestoro dnestoro self-assigned this Oct 23, 2023
@dnestoro dnestoro marked this pull request as draft October 23, 2023 13:05
@dnestoro dnestoro marked this pull request as ready for review October 26, 2023 19:44
melix
melix requested changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to update the samples to remove -Ob, don't you?

@dnestoro
Copy link
Collaborator Author

dnestoro commented Oct 27, 2023 •
edited

@melix if I search for -Ob in the samples nothing is found. Is it possible that samples have some other option set that will force tests to run in -Ob mode that should be removed (if not than I can't find this flag in samples anywhere)?

fniephaus
fniephaus approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnestoro dnestoro merged commit 87ca37d into graalvm:master Oct 27, 2023
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melix melix melix approved these changes

@fniephaus fniephaus fniephaus approved these changes

Assignees

@dnestoro dnestoro

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dnestoro @melix @fniephaus