Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant settings.gradle configuration #532

Merged
merged 1 commit into from Oct 23, 2023
Merged

Remove redundant settings.gradle configuration #532

merged 1 commit into from Oct 23, 2023

Conversation

melix
Copy link
Collaborator

@melix melix commented Oct 23, 2023

This is no longer required in recent Gradle versions.

Fixes #529

@melix
Remove redundant settings.gradle configuration
3fa3224 
This is no longer required in recent Gradle versions.

Fixes #529
@melix melix added documentation Improvements or additions to documentation gradle-plugin Related to Gradle plugin labels Oct 23, 2023
@melix melix added this to the 0.9.29 milestone Oct 23, 2023
@melix melix requested a review from fniephaus October 23, 2023 14:59
@melix melix self-assigned this Oct 23, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 23, 2023
fniephaus
fniephaus approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that is the kind the diff I like! 😉

@melix melix merged commit c5477c6 into master Oct 23, 2023
19 checks passed
@melix melix deleted the cc/issue-529 branch October 23, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fniephaus fniephaus fniephaus approved these changes

Assignees

@melix melix

Labels
documentation Improvements or additions to documentation gradle-plugin Related to Gradle plugin OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
0.9.29
Development

Successfully merging this pull request may close these issues.

Remove settings.gradle instructions
2 participants
@melix @fniephaus