Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Substitute <arg> with <buildArg> in Maven plugin doc. #551

Merged
merged 1 commit into from Jan 23, 2024
Merged

Substitute <arg> with <buildArg> in Maven plugin doc. #551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/docs/asciidoc/maven-plugin.adoc
View file
Open in desktop
Expand Up @@ -133,7 +133,7 @@ Build Configuration]. It is also possible to customize the plugin within a
[source,xml]
----
<buildArgs>
<arg>--argument</arg>
<buildArg>--argument</buildArg>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it change too for specifying JVM arguments?
Currently we have:

<jvmArgs>
    <arg>argument1</arg>
    <arg>argument2</arg>
</jvmArgs>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it ever changed, maybe it's Maven accepting both? @alvarosanchez wdyt?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for tags mapped as collections (like buildArgs), the inner tags can use any name. The convention is to use the singular form of the plural tag name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both!

</buildArgs>
----
`<skipNativeBuild>`::
Expand Down