Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Plugins Use Metadata Repository by Default #557

Merged
merged 3 commits into from Jan 23, 2024
Merged

Make Plugins Use Metadata Repository by Default #557

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19f3769
Make plugins use metadata repository by default
dnestoro Jan 12, 2024
02eb069
Change tests to expect new error when the repository cannot be pulled
dnestoro Jan 12, 2024
ee840ab
Refactor some comments and error messages
dnestoro Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 6 additions & 8 deletions ...unctionalTest/groovy/org/graalvm/buildtools/maven/MetadataRepositoryFunctionalTest.groovy
View file
Open in desktop
Expand Up @@ -87,17 +87,16 @@ class MetadataRepositoryFunctionalTest extends AbstractGraalVMMavenFunctionalTes
outputContains NATIVE_IMAGE_EXE + " --exclude-config dummy/path/to/file.jar \"*\""
}

void "if the path doesn't exist it throws an error"() {
void "if the path doesn't exist, the repository cannot be pulled"() {
given:
withSample("native-config-integration")

when:
mvn '-Pnative,metadataMissing', '-DquickBuild', '-DskipTests', 'package', 'exec:exec@native'

then:
buildSucceeded
outputContains "GraalVM reachability metadata repository path does not exist"
outputContains "Reflection failed"
buildFailed
outputContains " Cannot pull GraalVM reachability metadata repository either from the one specified in the configuration or the default one"
olpaw marked this conversation as resolved.
Show resolved Hide resolved
}

void "it can exclude dependencies"() {
Expand Down Expand Up @@ -163,7 +162,7 @@ class MetadataRepositoryFunctionalTest extends AbstractGraalVMMavenFunctionalTes
outputContains "[graalvm reachability metadata repository for org.graalvm.internal:library-with-reflection:1.5]: Configuration directory is org.graalvm.internal" + File.separator + "library-with-reflection" + File.separator + "1"
}

void "when pointing to a missing URL, reflection fails"() {
void "when pointing to a missing URL, the repository cannot be pulled"() {
given:
withSample("native-config-integration")
withLocalServer()
Expand All @@ -172,9 +171,8 @@ class MetadataRepositoryFunctionalTest extends AbstractGraalVMMavenFunctionalTes
mvn '-Pnative,metadataUrl', '-DquickBuild', "-Dmetadata.url=https://google.com/notfound", '-DskipTests', 'package', 'exec:exec@native'

then:
buildSucceeded
outputContains "Reflection failed"
outputContains "Failed to download from https://google.com/notfound: 404 Not Found"
buildFailed
outputContains "Cannot pull GraalVM reachability metadata repository either from the one specified in the configuration or the default one"
}

void "it can include hints in jar"() {
Expand Down