[575] junit-native does not support org.junit.rules.ExpectedException. #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tzezula
commented
Feb 19, 2024
common/junit-platform-native/src/main/java/org/graalvm/junit/platform/JUnitPlatformFeature.java
Outdated
Show resolved
Hide resolved
vjovanov
reviewed
Feb 20, 2024
| } | ||
| }; | ||
| if (typeSafeMatcher != null) { | ||
| access.registerSubtypeReachabilityHandler(registerMatcherForReflection, typeSafeMatcher); |
There was a problem hiding this comment.
How do we guarantee this does not affect user code by registering their classes?
There was a problem hiding this comment.
@vjovanov: Good question. I believe it's acceptable to register even the user classes. This is because subclasses of org.hamcrest.TypeSafeMatcher and org.hamcrest.TypeSafeDiagnosingMatcher that utilize the default constructor rely on Class.getDeclaredMethods() to function properly. You can refer to TypeSafeMatcher#TypeSafeMatcher(), which indirectly invokes ReflectiveTypeFinder#findExpectedType(). Ideally, we would only mark the matchesSafely method for getDeclaredMethods, but unfortunately, this is not possible.
|
@fniephaus I've added the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixies issue #575 by registering all used subclasses of
TypeSafeMatcherandTypeSafeDiagnosingMatcherfor reflective access to all declared methods.