fix: revert to react-scripts 4.0.3 (for uppy)

See transloadit/uppy#3376 BREAKING CHANGES
graasp · Mar 21, 2022 · e1cf13d · e1cf13d
1 parent 5198eb8
commit e1cf13d
Show file tree

Hide file tree

Showing 5 changed files with 5,608 additions and 3,034 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -18,10 +18,7 @@
     "cy": true,
     "Cypress": true
   },
-  "parser": "@babel/eslint-parser",
-  "parserOptions": {
-    "requireConfigFile": false
-  },
+  "parser": "babel-eslint",
   "rules": {
     "no-underscore-dangle": [
       "error",
@@ -46,9 +43,8 @@
         "extensions": [".js", ".jsx"]
       }
     ],
-    "react/jsx-no-constructed-context-values": ["warn"],
-    "react/function-component-definition": ["warn", {"namedComponents": "arrow-function"}],
     "react/static-property-placement": ["error", "static public field"],
+    "react/function-component-definition": ["warn", "arrow-function"],
     "jsx-a11y/click-events-have-key-events": ["warn"],
     "jsx-a11y/mouse-events-have-key-events": ["warn"],
     "import/no-named-as-default": 0

diff --git a/docs/update.md b/docs/update.md
@@ -0,0 +1,123 @@
+### Update
+
+.eslintrc
+
+`
+{
+  "extends": [
+    "airbnb",
+    "prettier"
+  ],
+  "plugins": [
+    "import",
+    "jsx-a11y",
+    "react"
+  ],
+  "env": {
+    "browser": true,
+    "node": true,
+    "mocha": true,
+    "jest": true
+  },
+  "globals": {
+    "cy": true,
+    "Cypress": true
+  },
+  "parser": "@babel/eslint-parser",
+  "parserOptions": {
+    "requireConfigFile": false
+  },
+  "rules": {
+    "no-underscore-dangle": [
+      "error",
+      {
+        "allow": [
+          "_id",
+          "__REDUX_DEVTOOLS_EXTENSION__"
+        ]
+      }
+    ],
+    "jsx-a11y/anchor-is-valid": [
+      "error",
+      {
+        "components": ["Link"],
+        "specialLink": ["to", "hrefLeft", "hrefRight"],
+        "aspects": ["noHref", "invalidHref", "preferButton"]
+      }
+    ],
+    "react/jsx-filename-extension": [
+      1,
+      {
+        "extensions": [".js", ".jsx"]
+      }
+    ],
+    "react/jsx-no-constructed-context-values": ["warn"],
+    "react/function-component-definition": ["warn", {"namedComponents": "arrow-function"}],
+    "react/static-property-placement": ["error", "static public field"],
+    "jsx-a11y/click-events-have-key-events": ["warn"],
+    "jsx-a11y/mouse-events-have-key-events": ["warn"],
+    "import/no-named-as-default": 0
+  }
+}{
+  "extends": [
+    "airbnb",
+    "prettier"
+  ],
+  "plugins": [
+    "import",
+    "jsx-a11y",
+    "react"
+  ],
+  "env": {
+    "browser": true,
+    "node": true,
+    "mocha": true,
+    "jest": true
+  },
+  "globals": {
+    "cy": true,
+    "Cypress": true
+  },
+  "parser": "@babel/eslint-parser",
+  "parserOptions": {
+    "requireConfigFile": false
+  },
+  "rules": {
+    "no-underscore-dangle": [
+      "error",
+      {
+        "allow": [
+          "_id",
+          "__REDUX_DEVTOOLS_EXTENSION__"
+        ]
+      }
+    ],
+    "jsx-a11y/anchor-is-valid": [
+      "error",
+      {
+        "components": ["Link"],
+        "specialLink": ["to", "hrefLeft", "hrefRight"],
+        "aspects": ["noHref", "invalidHref", "preferButton"]
+      }
+    ],
+    "react/jsx-filename-extension": [
+      1,
+      {
+        "extensions": [".js", ".jsx"]
+      }
+    ],
+    "react/jsx-no-constructed-context-values": ["warn"],
+    "react/function-component-definition": ["warn", {"namedComponents": "arrow-function"}],
+    "react/static-property-placement": ["error", "static public field"],
+    "jsx-a11y/click-events-have-key-events": ["warn"],
+    "jsx-a11y/mouse-events-have-key-events": ["warn"],
+    "import/no-named-as-default": 0
+  }
+}
+`
+
+package.json
+
+`
+"react-scripts": "~5.0.0",
+`
diff --git a/package.json b/package.json
@@ -12,7 +12,7 @@
   "license": "AGPL-3.0-only",
   "dependencies": {
     "@graasp/apps-query-client": "github:graasp/graasp-apps-query-client.git#18/appSettings",
-    "@graasp/ui": "github:graasp/graasp-ui.git#100/itemClassname",
+    "@graasp/ui": "github:graasp/graasp-ui.git",
     "@material-ui/core": "4.12.3",
     "@material-ui/icons": "4.11.2",
     "@material-ui/lab": "4.0.0-alpha.60",
@@ -34,7 +34,7 @@
     "react-dom": "~17.0.2",
     "react-ga": "~3.3.0",
     "react-i18next": "~11.15.6",
-    "react-scripts": "~5.0.0",
+    "react-scripts": "~4.0.3",
     "react-toastify": "~8.2.0",
     "stopword": "~2.0.1"
   },
@@ -61,9 +61,9 @@
     "release": "git fetch --tags && git add CHANGELOG.md && standard-version -a"
   },
   "devDependencies": {
-    "@babel/eslint-parser": "~7.17.0",
     "@commitlint/cli": "~16.2.1",
     "@commitlint/config-conventional": "~16.2.1",
+    "babel-eslint": "10.1.0",
     "codacy-coverage": "3.4.0",
     "cross-env": "7.0.3",
     "cypress": "~9.5.1",

diff --git a/src/components/main/Canvas.js b/src/components/main/Canvas.js
@@ -92,6 +92,7 @@ const Canvas = () => {
 
   /* The <div> element has a child <button> element that allows keyboard interaction */
   return (
+    /* eslint-disable-next-line react/jsx-no-constructed-context-values */
     <CanvasContext.Provider value={{
       noteBeingEditedId,
       setNoteBeingEditedId,