Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

API recorder broken on several demos #8259

Closed
1 task done
pngwn opened this issue May 10, 2024 · 2 comments 路 Fixed by #8247
Closed
1 task done

API recorder broken on several demos #8259

pngwn opened this issue May 10, 2024 · 2 comments 路 Fixed by #8247
Labels
bug Something isn't working

Comments

@pngwn
Copy link
Member

pngwn commented May 10, 2024

Describe the bug

The API recorder seems to work in simple cases but there are quite a few demos where it doesn't work.

Most notably it doesn't work with the ChatInterface.

Have you searched existing issues? 馃攷

  • I have searched and found no existing issues

Reproduction

https://huggingface.co/spaces/gradio/chatinterface_streaming_echo

https://huggingface.co/spaces/gradio/kitchen_sink

Do almost anything and record the requests, and it will break.

What isn't clear to me is how we are supposed to handle the API recorder if certain API requests are essentially 'hidden' from the client. What is more, we don't return info for unnamed routes from /info, so I'm not sure how we are supposed to get hold of this information. We somehow need to workaround these constraints for the API recorder to work.

Screenshot

No response

Logs

No response

System Info

-

Severity

I can work around it

@pngwn pngwn added the bug Something isn't working label May 10, 2024
@pngwn
Copy link
Member Author

pngwn commented May 10, 2024

In terms of what is happening. I'm pretty sure the API recorder works fine but we don't have the information required to build the queries correctly due to the various client changes + how the information to make those changes only applies to certain routes.

@freddyaboulton
Copy link
Collaborator

Also see #8246 for another case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants