Fix api recorder #8247
Merged
Fix api recorder #8247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/abb52a0f0105025a520584dd633508bf0eda6b40/gradio-4.31.3-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@abb52a0f0105025a520584dd633508bf0eda6b40#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
abidlabs
requested review from
aliabid94,
aliabd,
dawoodkhan82,
pngwn and
freddyaboulton
abidlabs
commented
May 17, 2024
| @@ -415,8 +416,11 @@ def main(request: fastapi.Request, user: str = Depends(get_current_user)): | |||
|
|
|||
| @app.get("/info/", dependencies=[Depends(login_check)]) | |||
| @app.get("/info", dependencies=[Depends(login_check)]) | |||
| def api_info(): | |||
| # The api info is set in create_app | |||
| def api_info(all_endpoints: bool = False): | |||
There was a problem hiding this comment.
Initially, I had implemented it so that the /info route just returned all of the endpoints, even those with show_api=False and we filtered in the frontend. However, this led to very, very large payloads for complex apps like the theme builder causing slow load times / crashing. We should figure out a way to reduce the payload for /info, but in the meantime, here we don't load all endpoints by default -- only if you use the API Recorder.
aliabd
approved these changes
May 17, 2024
|
Sweet thanks @aliabd! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where API Recorder would stop working (the fix was to explicitly handle the case where one of the inputs was
gr.State). Fixed for both the Python and JS code snippets.Closes: #8259 (test either of the demos locally)
Closes: #7982 (test on this Space with this PR installed)
Also fixes the RecordingSnippet for JS Client to ensure that it uses the new kwarg syntax instead of the positional syntax and adds an e2e -- the playwright api recorder helped me write the test hehe