Reduce the analytics that are collected in Gradio #8263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/840b6bef9cd79a01d3e0ab887f0c3e6ae3379d5c/gradio-4.31.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@840b6bef9cd79a01d3e0ab887f0c3e6ae3379d5c#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
abidlabs
requested review from
aliabid94,
aliabd,
dawoodkhan82,
pngwn,
hannahblair and
freddyaboulton
abidlabs
commented
May 13, 2024
| @@ -324,6 +324,7 @@ def test_upload_and_download_with_auth(self): | |||
| with open(output) as f: | |||
| assert f.read() == "Hello file!" | |||
|
|
|||
| @pytest.mark.flaky | |||
There was a problem hiding this comment.
unrelated but this is a flaky test and I'm not sure why
freddyaboulton
approved these changes
May 13, 2024
|
Looks great @abidlabs ! |
aliabid94
reviewed
May 13, 2024
| @@ -464,3 +465,17 @@ demo.launch(max_file_size=5 * gr.FileSize.MB) | |||
| ``` | |||
|
|
|||
| Please make sure you are running the latest version of `gradio` for these security settings to apply. | |||
|
|
|||
There was a problem hiding this comment.
Personally think this is way too much content about analytics in the getting started guide @abidlabs
There was a problem hiding this comment.
This guide is no longer in the getting started section :)
Merged
julien-c
reviewed
May 14, 2024
| * What environment the Gradio app is running on (e.g. Colab Notebook, Hugging Face Spaces) | ||
| * What input/output components are being used in the Gradio app | ||
| * Whether the Gradio app is utilizing certain advanced features, such as `auth` or `show_error` | ||
| * The IP address which is used solely to measure the number of unique developers using Gradio |
There was a problem hiding this comment.
maybe more precise The IP address of the server?
There was a problem hiding this comment.
Ah yeah let me fix in another pr
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Google Analytics from Gradio apps and document the analytics that we do track from developers.