Extracting source/resources required for the GradleRunner tests #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprinet
approved these changes
Mar 22, 2023
| '''.stripIndent() | ||
| } | ||
|
|
||
| static String strings() { |
There was a problem hiding this comment.
I find this method name a bit confusing
There was a problem hiding this comment.
done, changed to getXmlStrings
runningcode
reviewed
Mar 22, 2023
| @@ -0,0 +1,13 @@ | |||
| package org.gradle.android.writer | |||
|
|
|||
| class Kotlin { | |||
There was a problem hiding this comment.
I dislike the name Kotlin as a class name. I'm thinking it might be better to group these code writing classes to something like CodeSnippets. Then we can call CodeSnippets.getKotlinDataClass() and CodeSnippets.getJavaClass(). WDYT?
There was a problem hiding this comment.
sounds good.
Grouped all sources/resources inCodeSnippets c101f75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleAndroid class is getting complex, and with more use cases to cover the class is getting hard to maintain.
Before starting the rework of the class(#460) we need to clean up the current class.
This PR extracts classes/resources used in the "Simple" projects run under the Gradle Runner tests