Develocity Gradle plugin is removed from convention plugin sample

[erichaagdev]

As it exists today, the user is prompted to publish the scan to scans.gradle.com. This is because the Develocity Gradle plugin is applied, but not configured.

This change removes the Develocity Gradle and CCUD plugins.

[etiennestuder]

I think we should no integrate this PR.

[etiennestuder]

Not sure what you mean with this comment. There is no plan to publish this convention plugin. It serves as a template that other can copy and adjust to their needs.

[etiennestuder]

@erichaagdev Instead of adding the DV configuration to the settings.file, I would remove the DV/CCUD plugin declarations. The reason being that this project is an example of how to build a convention plugin, not how to configure a project with DV.

[erichaagdev]

I don't understand the motivation of this PR.

@etiennestuder the motivation was that I ran the build and was prompted to agree to the Gradle ToS to publish a scan to scans.gradle.com. This is because the build had the Develocity Gradle plugin applied, but it was not configured. This didn't feel right. I felt either of these options would be improvements over that state:

1. Configure the Develocity Gradle plugin
2. Remove the Develocity Gradle plugin

I chose option 1 to encourage and remind users that this build should also be connected to Develocity once it is copied. I chose develocity-samples.gradle.com as this is the same hypothetical server the convention plugin configures. 

But, maybe a better option is to remove Develocity Gradle plugin and CCUD as you say. We could then add this to the settings.gradle file instead: 

plugins {
    // CHANGE ME: Apply your convention plugin once published
    // plugin('com.myorg.convention-develocity-gradle-5-or-newer') version '1.0.0'
    ..
}

This is the same pattern we follow for the rest of this template:

develocity-build-config-samples/convention-develocity-gradle-plugin/plugins/gradle-5-or-newer/src/main/java/com/myorg/ConventionDevelocityGradlePlugin.java

Line 60 in 82714f7

// CHANGE ME: Apply your Develocity configuration here

What do you think about this?

[etiennestuder]

What do you think about this?

Yep. I fully agree with your option #2.

#1186 (comment)