Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix save/restore of configuration-cache #302

Merged
merged 5 commits into from Jun 4, 2022
Merged

Fix save/restore of configuration-cache #302

merged 5 commits into from Jun 4, 2022

Commits on Jun 3, 2022

  1. Make build-result-capture script compatible with config-cache

    @bigdaz
    bigdaz committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    6cc033f View commit details
    Browse the repository at this point in the history

  2. Update comment for accuracy

    @bigdaz
    bigdaz committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    cde0632 View commit details
    Browse the repository at this point in the history

  3. Use a BuildService to always collect project root 

    Using `settingsEvaluated` meant that the project root was not recorded
when the build was run with a config-cache hit. This meant that the subsequent
build would not restore the config-cache, resulting in a cache miss.

In order to avoid issues running the init script on older versions of Gradle
the project-collection is extracted into a separate groovy file that is only
applied conditionally on Gradle 7 or higher.
    @bigdaz
    bigdaz committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    ae74c01 View commit details
    Browse the repository at this point in the history

  4. Remove debug output from init script

    @bigdaz
    bigdaz committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    dff0fe1 View commit details
    Browse the repository at this point in the history

  5. Build outputs

    @bigdaz
    bigdaz committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    4da2997 View commit details
    Browse the repository at this point in the history