Add execute-command-before BuildMutator #310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexBeggs
force-pushed
the
execute-command-before-build-mutator
branch
from
34a5304
to
8bd8259
Compare
AlexBeggs
commented
Feb 7, 2021
AlexBeggs
commented
Feb 7, 2021
AlexBeggs
commented
Feb 7, 2021
AlexBeggs
commented
Feb 7, 2021
| } | ||
|
|
||
| public enum ExecuteCommandSchedule { | ||
| SCENARIO, BUILD |
There was a problem hiding this comment.
doesn't handle CLEANUP, Bazel, Buck and Maven don't implement that
AlexBeggs
commented
Feb 7, 2021
| .redirectOutput(ProcessBuilder.Redirect.INHERIT) | ||
| .redirectError(ProcessBuilder.Redirect.INHERIT); | ||
| Process process = processBuilder.start(); | ||
| return process.waitFor(); |
There was a problem hiding this comment.
could potentially add a timeout option but for now I left it
AlexBeggs
force-pushed
the
execute-command-before-build-mutator
branch
8 times, most recently
from
b1d27b8
to
f34a35c
Compare
AlexBeggs
force-pushed
the
execute-command-before-build-mutator
branch
2 times, most recently
from
d4c772c
to
3d31a95
Compare
AlexBeggs
commented
Feb 8, 2021
| @@ -212,80 +218,26 @@ public ScenarioLoader(GradleBuildConfigurationReader gradleBuildConfigurationRea | |||
| String title = scenario.hasPath(TITLE) ? scenario.getString(TITLE) : null; | |||
|
|
|||
| List<BuildMutator> mutators = BUILD_MUTATOR_CONFIGURATORS.entrySet().stream() | |||
| .filter(entry -> scenario.hasPath(entry.getKey())) | |||
There was a problem hiding this comment.
filtering isn't done here. The BuildMutator's should be responsible for determining if they support the configuration or not.
- BuildMutator allows commands to be executed prior to the SCENARIO or BUILD phase. Enabled for all types of builds, Gradle, Bazel, Buck, and Maven. Signed-off-by: Alex Beggs <sunyal@gmail.com>
AlexBeggs
force-pushed
the
execute-command-before-build-mutator
branch
from
3d31a95
to
c1b2376
Compare
|
Does this run commands in the root directory of the project? It would be helpful I think to have an example that runs a script that is local to the project being profiled since I think that would be a common case. |
|
If I recall correctly, this runs the command in the working directory or |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #315