Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ScenarioLoader #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor ScenarioLoader #314

wants to merge 1 commit into from

Conversation

AlexBeggs
Copy link
Contributor

  • separate large section of code into multiple methods for clarity

@lptr lptr self-assigned this Feb 8, 2021
@lptr lptr added @execution internal Internal change and removed enhancement labels Feb 8, 2021
@lptr lptr self-requested a review February 8, 2021 19:38
lptr
lptr reviewed Feb 8, 2021
View reviewed changes
Copy link
Member

@lptr lptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements, I left a couple comments.

src/main/java/org/gradle/profiler/ScenarioLoader.java Outdated Show resolved Hide resolved
src/main/java/org/gradle/profiler/ScenarioLoader.java Show resolved Hide resolved
@AlexBeggs
Refactor ScenarioLoader
e2c4553 
- extract large method into separate methods for the different build scenarios

Signed-off-by: Alex Beggs <sunyal@gmail.com>
@lptr lptr removed the @execution label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lptr lptr lptr left review comments

Assignees

@lptr lptr

Labels
internal Internal change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexBeggs @lptr