Fix build logic instrumentation to handle GString parameters to Java …

…system property query methods.
gradle · Jun 29, 2020 · 2f05d9b · 2f05d9b
1 parent d0940a5
commit 2f05d9b
Showing 1 changed file with 24 additions and 17 deletions.
diff --git a/subprojects/core/src/main/java/org/gradle/internal/classpath/Instrumented.java b/subprojects/core/src/main/java/org/gradle/internal/classpath/Instrumented.java
@@ -49,18 +49,25 @@ public static void discardListener() {
     }
 
     // Called by generated code
+    @SuppressWarnings("unused")
     public static void groovyCallSites(CallSiteArray array) {
         for (CallSite callSite : array.array) {
-            if (callSite.getName().equals("getProperty")) {
-                array.array[callSite.getIndex()] = new SystemPropertyCallSite(callSite);
-            } else if (callSite.getName().equals("properties")) {
-                array.array[callSite.getIndex()] = new SystemPropertiesCallSite(callSite);
-            } else if (callSite.getName().equals("getInteger")) {
-                array.array[callSite.getIndex()] = new IntegerSystemPropertyCallSite(callSite);
-            } else if (callSite.getName().equals("getLong")) {
-                array.array[callSite.getIndex()] = new LongSystemPropertyCallSite(callSite);
-            } else if (callSite.getName().equals("getBoolean")) {
-                array.array[callSite.getIndex()] = new BooleanSystemPropertyCallSite(callSite);
+            switch (callSite.getName()) {
+                case "getProperty":
+                    array.array[callSite.getIndex()] = new SystemPropertyCallSite(callSite);
+                    break;
+                case "properties":
+                    array.array[callSite.getIndex()] = new SystemPropertiesCallSite(callSite);
+                    break;
+                case "getInteger":
+                    array.array[callSite.getIndex()] = new IntegerSystemPropertyCallSite(callSite);
+                    break;
+                case "getLong":
+                    array.array[callSite.getIndex()] = new LongSystemPropertyCallSite(callSite);
+                    break;
+                case "getBoolean":
+                    array.array[callSite.getIndex()] = new BooleanSystemPropertyCallSite(callSite);
+                    break;
             }
         }
     }
@@ -353,7 +360,7 @@ public IntegerSystemPropertyCallSite(CallSite callSite) {
         @Override
         public Object call(Object receiver, Object arg) throws Throwable {
             if (receiver.equals(Integer.class)) {
-                return getInteger((String) arg, array.owner.getName());
+                return getInteger(arg.toString(), array.owner.getName());
             } else {
                 return super.call(receiver, arg);
             }
@@ -362,7 +369,7 @@ public Object call(Object receiver, Object arg) throws Throwable {
         @Override
         public Object call(Object receiver, Object arg1, Object arg2) throws Throwable {
             if (receiver.equals(Integer.class)) {
-                return getInteger((String) arg1, (Integer) unwrap(arg2), array.owner.getName());
+                return getInteger(arg1.toString(), (Integer) unwrap(arg2), array.owner.getName());
             } else {
                 return super.call(receiver, arg1, arg2);
             }
@@ -377,7 +384,7 @@ public LongSystemPropertyCallSite(CallSite callSite) {
         @Override
         public Object call(Object receiver, Object arg) throws Throwable {
             if (receiver.equals(Long.class)) {
-                return getLong((String) arg, array.owner.getName());
+                return getLong(arg.toString(), array.owner.getName());
             } else {
                 return super.call(receiver, arg);
             }
@@ -386,7 +393,7 @@ public Object call(Object receiver, Object arg) throws Throwable {
         @Override
         public Object call(Object receiver, Object arg1, Object arg2) throws Throwable {
             if (receiver.equals(Long.class)) {
-                return getLong((String) arg1, (Long) unwrap(arg2), array.owner.getName());
+                return getLong(arg1.toString(), (Long) unwrap(arg2), array.owner.getName());
             } else {
                 return super.call(receiver, arg1, arg2);
             }
@@ -401,7 +408,7 @@ public BooleanSystemPropertyCallSite(CallSite callSite) {
         @Override
         public Object call(Object receiver, Object arg) throws Throwable {
             if (receiver.equals(Boolean.class)) {
-                return getBoolean((String) arg, array.owner.getName());
+                return getBoolean(arg.toString(), array.owner.getName());
             } else {
                 return super.call(receiver, arg);
             }
@@ -416,7 +423,7 @@ public SystemPropertyCallSite(CallSite callSite) {
         @Override
         public Object call(Object receiver, Object arg) throws Throwable {
             if (receiver.equals(System.class)) {
-                return systemProperty((String) arg, array.owner.getName());
+                return systemProperty(arg.toString(), array.owner.getName());
             } else {
                 return super.call(receiver, arg);
             }
@@ -425,7 +432,7 @@ public Object call(Object receiver, Object arg) throws Throwable {
         @Override
         public Object call(Object receiver, Object arg1, Object arg2) throws Throwable {
             if (receiver.equals(System.class)) {
-                return systemProperty((String) arg1, (String) arg2, array.owner.getName());
+                return systemProperty(arg1.toString(), arg2.toString(), array.owner.getName());
             } else {
                 return super.call(receiver, arg1, arg2);
             }