Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove constant usage analysis in favor of full recompilation.
This commit fixes #1474, by not relying on the analysis of literals (which still exists), but rather recompiling everything whenever we detect that a constant effectively changed in a class. This doesn't prevent us from using a smarter strategy later (say, using a compiler plugin). The commit also changes the hash that is used to store constants, so that the name of the constant is used. This prevents another bug which was that if a class has multiple variants of the same value, or that values of several constants are switched, we wouldn't detect the change.
- Loading branch information
Showing
6 changed files
with
62 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters