Use AtomicInteger for detached configuration name counter

Signed-off-by: Volker Leck <volker@gradle.com>
gradle · Oct 11, 2019 · 4748a15 · 4748a15
1 parent 20957bd
commit 4748a15
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/.../java/org/gradle/api/internal/artifacts/configurations/DefaultConfigurationContainer.java b/.../java/org/gradle/api/internal/artifacts/configurations/DefaultConfigurationContainer.java
@@ -58,6 +58,7 @@
 
 import java.util.Collection;
 import java.util.Set;
+import java.util.concurrent.atomic.AtomicInteger;
 
 public class DefaultConfigurationContainer extends AbstractValidatingNamedDomainObjectContainer<Configuration>
     implements ConfigurationContainerInternal, ConfigurationsProvider {
@@ -79,7 +80,7 @@ public class DefaultConfigurationContainer extends AbstractValidatingNamedDomain
     private final ProjectStateRegistry projectStateRegistry;
     private final DocumentationRegistry documentationRegistry;
 
-    private int detachedConfigurationDefaultNameCounter = 1;
+    private final AtomicInteger detachedConfigurationDefaultNameCounter = new AtomicInteger(1);
     private final Factory<ResolutionStrategyInternal> resolutionStrategyFactory;
     private final DefaultRootComponentMetadataBuilder rootComponentMetadataBuilder;
     private final DomainObjectCollectionFactory domainObjectCollectionFactory;
@@ -161,7 +162,7 @@ protected UnknownDomainObjectException createNotFoundException(String name) {
 
     @Override
     public ConfigurationInternal detachedConfiguration(Dependency... dependencies) {
-        String name = DETACHED_CONFIGURATION_DEFAULT_NAME + detachedConfigurationDefaultNameCounter++;
+        String name = DETACHED_CONFIGURATION_DEFAULT_NAME + detachedConfigurationDefaultNameCounter.getAndIncrement();
         DetachedConfigurationsProvider detachedConfigurationsProvider = new DetachedConfigurationsProvider();
         DefaultConfiguration detachedConfiguration = instantiator.newInstance(DefaultConfiguration.class,
             context, name, detachedConfigurationsProvider, resolver,