Skip to content

Commit

Permalink
Merge pull request #10378 from gradle/eskatos/kotlin/upgrade-ktlint-c…
Browse files Browse the repository at this point in the history
…onvention

Upgrade ktlint-convention plugin to the latest
  • Loading branch information
eskatos committed Aug 28, 2019
2 parents 64f36e4 + 44fe5f4 commit 5cffc41
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion buildSrc/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import java.util.Properties
plugins {
`java`
`kotlin-dsl` apply false
id("org.gradle.kotlin-dsl.ktlint-convention") version "0.3.0" apply false
id("org.gradle.kotlin-dsl.ktlint-convention") version "0.4.1" apply false
}

subprojects {
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/subprojects/kotlin-dsl/kotlin-dsl.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ dependencies {
api(kotlin("reflect"))
api(kotlin("compiler-embeddable"))

implementation("org.gradle.kotlin:gradle-kotlin-dsl-conventions:0.3.0")
implementation("org.gradle.kotlin:gradle-kotlin-dsl-conventions:0.4.1")
implementation("com.gradle.publish:plugin-publish-plugin:0.10.0")

implementation("com.thoughtworks.qdox:qdox:2.0-M9")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class PrecompiledScriptPluginIntegrationTest : AbstractPluginIntegrationTest() {
withBuildScript("""
plugins {
`kotlin-dsl`
id("org.gradle.kotlin-dsl.ktlint-convention") version "0.3.0"
id("org.gradle.kotlin-dsl.ktlint-convention") version "0.4.1"
}
$repositoriesBlock
Expand All @@ -41,8 +41,7 @@ class PrecompiledScriptPluginIntegrationTest : AbstractPluginIntegrationTest() {

build("generateScriptPluginAdapters")

executer.expectDeprecationWarning()
build("ktlintC")
build("ktlintCheck", "-x", "ktlintKotlinScriptCheck")
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ dependencies {
implementation(futureKotlin("scripting-compiler-impl-embeddable")) {
isTransitive = false
}

implementation(library("slf4j_api"))

testImplementation(project(":kotlinDslTestFixtures"))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ gradlebuildJava {

dependencies {
api(project(":kotlinDsl"))

implementation(project(":baseServices"))
implementation(project(":coreApi"))
implementation(project(":core"))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ dependencies {
crossVersionTestImplementation(library("ant"))
crossVersionTestRuntimeOnly(project(":pluginDevelopment"))
crossVersionTestRuntimeOnly(project(":runtimeApiInfo"))

}

tasks {
Expand Down
2 changes: 1 addition & 1 deletion subprojects/soak/soak.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ dependencies {
integTestImplementation(project(":launcher"))
integTestImplementation(library("slf4j_api"))
integTestImplementation(testLibrary("jetty"))

integTestRuntimeOnly(project(":runtimeApiInfo"))
}

Expand Down

0 comments on commit 5cffc41

Please sign in to comment.