Polish BuildOperationCrossProjectConfigurator

- Inline constants used only once - Remove unnecessary `toString()` call
gradle · May 9, 2024 · 5ed9c08 · 5ed9c08
1 parent 69483fc
commit 5ed9c08
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/...src/main/java/org/gradle/api/internal/project/BuildOperationCrossProjectConfigurator.java b/...src/main/java/org/gradle/api/internal/project/BuildOperationCrossProjectConfigurator.java
@@ -76,13 +76,9 @@ public MutationGuard getMutationGuard() {
         return mutationGuard;
     }
 
-    private final static String ALLPROJECTS = "allprojects";
-    private final static String SUBPROJECTS = "subprojects";
-    private final static String ROOTPROJECT = "rootProject";
-
-    private final static BuildOperationDescriptor.Builder ALLPROJECTS_DETAILS = computeConfigurationBlockBuildOperationDetails(ALLPROJECTS);
-    private final static BuildOperationDescriptor.Builder SUBPROJECTS_DETAILS = computeConfigurationBlockBuildOperationDetails(SUBPROJECTS);
-    private final static BuildOperationDescriptor.Builder ROOT_PROJECT_DETAILS = computeConfigurationBlockBuildOperationDetails(ROOTPROJECT);
+    private final static BuildOperationDescriptor.Builder ALLPROJECTS_DETAILS = computeConfigurationBlockBuildOperationDetails("allprojects");
+    private final static BuildOperationDescriptor.Builder SUBPROJECTS_DETAILS = computeConfigurationBlockBuildOperationDetails("subprojects");
+    private final static BuildOperationDescriptor.Builder ROOT_PROJECT_DETAILS = computeConfigurationBlockBuildOperationDetails("rootProject");
 
     private static BuildOperationDescriptor.Builder computeConfigurationBlockBuildOperationDetails(String configurationBlockName) {
         return BuildOperationDescriptor.displayName("Execute '" + configurationBlockName + " {}' action").name(configurationBlockName);
@@ -122,7 +118,7 @@ private CrossConfigureProjectBuildOperation(Project project) {
 
         @Override
         public BuildOperationDescriptor.Builder description() {
-            String name = "Cross-configure project " + ((ProjectInternal) project).getIdentityPath().toString();
+            String name = "Cross-configure project " + ((ProjectInternal) project).getIdentityPath();
             return BuildOperationDescriptor.displayName(name);
         }
     }