Lazily index constraints

It's not necessary to build the constraint index map if, for a node, a constraint will never be lazily activated.
gradle · May 9, 2019 · cc97554 · cc97554
1 parent 123c41b
commit cc97554
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/...egTest/groovy/org/gradle/integtests/resolve/alignment/ForcingPlatformAlignmentTest.groovy b/...egTest/groovy/org/gradle/integtests/resolve/alignment/ForcingPlatformAlignmentTest.groovy
@@ -803,7 +803,6 @@ include 'other'
     @RequiredFeatures([
             @RequiredFeature(feature = GradleMetadataResolveRunner.REPOSITORY_TYPE, value = "maven"),
             @RequiredFeature(feature = GradleMetadataResolveRunner.EXPERIMENTAL_RESOLVE_BEHAVIOR, value = "true"),
-            @RequiredFeature(feature = GradleMetadataResolveRunner.GRADLE_METADATA, value = "false"),
     ])
     def "can force a published platform version by forcing the platform itself via a dependency"() {
         repository {

diff --git a/...a/org/gradle/api/internal/artifacts/ivyservice/resolveengine/graph/builder/NodeState.java b/...a/org/gradle/api/internal/artifacts/ivyservice/resolveengine/graph/builder/NodeState.java
@@ -362,6 +362,7 @@ private List<? extends DependencyMetadata> dependencies() {
         if (dependenciesMayChange) {
             cachedDependencyStates = null;
             cachedFilteredDependencyStates = null;
+            moduleIdToConstraints = null;
         }
         return metaData.getDependencies();
     }
@@ -391,12 +392,7 @@ private List<DependencyState> cacheDependencyStates(List<? extends DependencyMet
         int size = dependencies.size();
         List<DependencyState> tmp = Lists.newArrayListWithCapacity(size);
         for (DependencyMetadata dependency : dependencies) {
-            DependencyState ds = cachedDependencyStateFor(dependency);
-            if (dependency.isConstraint()) {
-                initializeModuleIdToConstraintMap(size);
-                moduleIdToConstraints.put(ds.getModuleIdentifier(), ds);
-            }
-            tmp.add(ds);
+            tmp.add(cachedDependencyStateFor(dependency));
         }
         return tmp;
     }
@@ -419,7 +415,13 @@ private void createAndLinkEdgeState(DependencyState dependencyState, Collection<
      */
     private void visitAdditionalConstraints(Collection<EdgeState> discoveredEdges) {
         if (moduleIdToConstraints == null) {
-            return;
+            for (DependencyState dependencyState : cachedDependencyStates) {
+                DependencyMetadata dependency = dependencyState.getDependency();
+                if (dependency.isConstraint()) {
+                    initializeModuleIdToConstraintMap(cachedDependencyStates.size());
+                    moduleIdToConstraints.put(dependencyState.getModuleIdentifier(), dependencyState);
+                }
+            }
         }
         for (ModuleIdentifier module : upcomingNoLongerPendingConstraints) {
             Collection<DependencyState> dependencyStates = moduleIdToConstraints.get(module);