Skip to content

Commit

Permalink
Restrict base version for cross version test
Browse files Browse the repository at this point in the history
So it doesn't try to run on pre 5.x versions. PathSensitivity has been
introduced in 3.1, though it doesn't make much sense to run the test
pre 5.0.

#11330
  • Loading branch information
wolfs committed Nov 13, 2019
1 parent daf7c6c commit fe767c9
Showing 1 changed file with 4 additions and 1 deletion.
Expand Up @@ -43,6 +43,7 @@ import org.gradle.plugins.ide.idea.GenerateIdeaProject
import org.gradle.plugins.ide.idea.GenerateIdeaWorkspace
import org.gradle.plugins.signing.Sign
import org.gradle.util.GradleVersion
import org.junit.Assume
import spock.lang.Issue

/**
Expand Down Expand Up @@ -214,6 +215,8 @@ apply plugin: SomePlugin

@Issue("https://github.com/gradle/gradle/issues/11330")
def "a subclass of JavaCompile with getSources receives the correct incremental changes"() {
// There is no use to make the test work pre-5.0, since the regression was introduced in 6.0
Assume.assumeTrue(previous.version.baseVersion >= GradleVersion.version("5.0"))
given:
file("producer/build.gradle") << """
apply plugin: 'java'
Expand Down Expand Up @@ -255,7 +258,7 @@ apply plugin: SomePlugin
apply plugin: 'java'
tasks.register("myJavaCompile", MyCompileTask) {
task myJavaCompile(type: MyCompileTask) {
def sourceSet = sourceSets.main
def sourceDirectorySet = sourceSet.java
addSource(sourceDirectorySet)
Expand Down

0 comments on commit fe767c9

Please sign in to comment.