Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align no isolation worker api classloader requirement with isolated modes #10357

Closed
ghale opened this issue Aug 23, 2019 · 0 comments · Fixed by #10910
Closed

Align no isolation worker api classloader requirement with isolated modes #10357

ghale opened this issue Aug 23, 2019 · 0 comments · Fixed by #10910
Labels
@core Issue owned by GBT Core in:workers
Milestone

Comments

@ghale
Copy link
Member

ghale commented Aug 23, 2019

Although no-isolation workers don't have any classloader isolation, they do have the requirement that they run in the same classloader as the task that submits them. We've recently discovered that there is a pathological case in composite builds where a worker can accidentally get a classloader from a different build in the composite (see #10317). We have a hacky fix for this in 5.6.1 (#10335), but we should come up with a better solution that aligns this requirement with how we communicate the classloader requirements for the classloader isolation and process isolation cases.

@ghale ghale added @core Issue owned by GBT Core from:member in:workers labels Aug 23, 2019
@ghale ghale added this to the 6.0 RC1 milestone Aug 23, 2019
@big-guy big-guy modified the milestones: 6.0 RC1, 6.1 RC1 Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@core Issue owned by GBT Core in:workers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants