Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of Worker API internals #10910

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Cleanup of Worker API internals #10910

merged 2 commits into from
Oct 17, 2019

Conversation

ghale
Copy link
Member

@ghale ghale commented Sep 30, 2019

Does two things:

  • Does some cleanup to use lambdas where possible in the Worker API classes
  • Aligns no-isolation workers with isolated workers by introducing a WorkerRequirement abstraction that allows the context classloader to be passed along without the need for a wrapper worker class.

Fixes #10357

@ghale ghale added from:member a:chore Minor issue without significant impact in:workers @core Issue owned by GBT Core labels Sep 30, 2019
@ghale ghale added this to the 6.1 RC1 milestone Sep 30, 2019
@ghale ghale requested a review from big-guy September 30, 2019 16:48
@ghale ghale self-assigned this Sep 30, 2019
@lacasseio
Copy link
Contributor

It looks pretty straightforward changes.

@lacasseio lacasseio merged commit b4a139a into master Oct 17, 2019
@ghale ghale deleted the gh/worker-api/worker-requirement branch May 1, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@big-guy big-guy Awaiting requested review from big-guy

Assignees

@ghale ghale

Labels
a:chore Minor issue without significant impact @core Issue owned by GBT Core in:workers
Projects
None yet
Milestone
6.1 RC1
Development

Successfully merging this pull request may close these issues.

Align no isolation worker api classloader requirement with isolated modes
2 participants
@ghale @lacasseio