Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the Kotlin DSL IDE script editor resolver support non-jvm IJ projects #9299

Closed
eskatos opened this issue Apr 26, 2019 · 3 comments
Closed
Assignees
Labels
a:feature A new functionality in:kotlin-dsl
Milestone

Comments

@eskatos
Copy link
Member

eskatos commented Apr 26, 2019

This is about supporting the rich Kotlin DSL script editor in IntelliJ projects that are not JVM based, e.g. python, javascript, native ...

Expected Behavior

Editing a .gradle.kts script in IntelliJ IDEs in a Gradle project that is not JVM based, iow where the Project SDK isn't a JVM, should work in the same way as with JVM based projects.

Current Behavior

Non JVM based IntelliJ IDEs don't support the rich Kotlin DSL script editor for .gradle.kts files when the Project SDK is not a JVM.

Implementation notes

This will require coordinated changes to both the Kotlin IntelliJ Plugin and Gradle.

First, https://youtrack.jetbrains.com/issue/KT-31152 need to be fixed in a released Kotlin version.

Then our KotlinBuildScriptDependenciesResolver need to relay the javaHome environment in the returned script dependencies.

For more details, see the original report gradle/kotlin-dsl-samples#1354.

A previous attempt was made in Gradle 5.4 #8756 but it made that Kotlin issue linked above very visible, hence reverted in Gradle 5.4.1 #9195

@eskatos
Copy link
Member Author

eskatos commented Jun 6, 2019

KT-31152 is marked as fixed for Kotlin 1.3.50

@NataliaUkhorskaya
Copy link

@eskatos Yes, the fix was chipped with 1.3.50. So is it possible to revert the fix in some next version of Gradle?

@eskatos
Copy link
Member Author

eskatos commented Sep 18, 2019

Fixed in #10350, will ship in 6.0

@eskatos eskatos closed this as completed Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:feature A new functionality in:kotlin-dsl
Projects
None yet
Development

No branches or pull requests

2 participants