Let Kotlin DSL IJ script resolver return given Java home #10350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskatos
changed the title
eskatos
force-pushed
the
eskatos/kotlin-dsl/resolver-java-home
branch
from
0ae16f5
to
c47b255
Compare
bamboo
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reinstatement of #8756 as a fix for #9299.
This will make IDEs with the IntelliJ Kotlin Plugin 1.3.50 use the correct JVM for TAPI requests. IDEs using previous Kotlin Plugin versions will be given the Project SDK instead of the Gradle JVM breaking the general use case to use a different JVM in Gradle JVM and Project SDK, see
#9195 for more information.
IDEs using Kotlin Plugin >= 1.3.50 will support the general use case to use a different JVM in Gradle JVM and Project SDK properly. And it will be possible to edit
.gradle.ktsfiles in non-JVM IntelliJ projects, that is without a JVM Project SDK, and in non JVM IDEs like Clion, Webstorm etc... Note that more changes on top of this one might be required in such IDEs.