Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AtomicInteger for detached configuration name counter #10286

Merged
merged 1 commit into from Aug 16, 2019
Merged

Use AtomicInteger for detached configuration name counter #10286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions .../java/org/gradle/api/internal/artifacts/configurations/DefaultConfigurationContainer.java
View file
Open in desktop
Expand Up @@ -58,6 +58,7 @@

import java.util.Collection;
import java.util.Set;
import java.util.concurrent.atomic.AtomicInteger;

public class DefaultConfigurationContainer extends AbstractValidatingNamedDomainObjectContainer<Configuration>
implements ConfigurationContainerInternal, ConfigurationsProvider {
Expand All @@ -79,7 +80,7 @@ public class DefaultConfigurationContainer extends AbstractValidatingNamedDomain
private final ProjectStateRegistry projectStateRegistry;
private final DocumentationRegistry documentationRegistry;

private int detachedConfigurationDefaultNameCounter = 1;
private final AtomicInteger detachedConfigurationDefaultNameCounter = new AtomicInteger(1);
private final Factory<ResolutionStrategyInternal> resolutionStrategyFactory;
private final DefaultRootComponentMetadataBuilder rootComponentMetadataBuilder;
private final DomainObjectCollectionFactory domainObjectCollectionFactory;
Expand Down Expand Up @@ -161,7 +162,7 @@ protected UnknownDomainObjectException createNotFoundException(String name) {

@Override
public ConfigurationInternal detachedConfiguration(Dependency... dependencies) {
String name = DETACHED_CONFIGURATION_DEFAULT_NAME + detachedConfigurationDefaultNameCounter++;
String name = DETACHED_CONFIGURATION_DEFAULT_NAME + detachedConfigurationDefaultNameCounter.getAndIncrement();
DetachedConfigurationsProvider detachedConfigurationsProvider = new DetachedConfigurationsProvider();
DefaultConfiguration detachedConfiguration = instantiator.newInstance(DefaultConfiguration.class,
context, name, detachedConfigurationsProvider, resolver,
Expand Down