Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression #10369

Merged
merged 3 commits into from Aug 27, 2019
Merged

Fix regression #10369

merged 3 commits into from Aug 27, 2019

Conversation

big-guy
Copy link
Member

@big-guy big-guy commented Aug 26, 2019

Fixes #?

Context

Contributor Checklist

  • Review Contribution Guidelines
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
  • Provide unit tests (under <subproject>/src/test) to verify logic
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation
  • Recognize contributor in release notes

blindpirate and others added 3 commits August 23, 2019 12:07
@blindpirate
Override getResources in DefaultDeprecatedClassLoader
07e3e0d 
This fixes #10347

In #9898 we introduced a DefaultDeprecatedClassLoader,
which overrides getResource() but not getResources(). This causes some issues.
This PR fixes the issue by correctly overriding getResources() method.
@big-guy
Merge remote-tracking branch 'origin/blindpirate/fix-10347' into release
0727e5a 
* origin/blindpirate/fix-10347:
  Override getResources in DefaultDeprecatedClassLoader
@big-guy
Avoid sharing the same id for the deprecated classloader as the real …
b220422 
…classloader
@big-guy big-guy merged commit d62577e into release Aug 27, 2019
@lptr
Copy link
Member

lptr commented Aug 27, 2019

This fixes #10347 right?

@big-guy
Copy link
Member Author

big-guy commented Aug 27, 2019

Yep, I forgot to include it

@big-guy big-guy deleted the sg/regressions/deprecated-classloader branch September 12, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@big-guy @lptr @blindpirate