Prevent memory leaks across builds when using worker API #10433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r daemon WorkerDaemonClients are retained across builds, so any object associated with it must not contain project state since this will be kept around until the worker expires. - Introduce a newDecoratedJavaForkOptions which creates a decorated JavaForkOptionsInternal - Replace calls to the decorated version of the method with non-decorated versions where appropriate
ghale
approved these changes
Sep 3, 2019
| @@ -190,6 +190,36 @@ class WorkerExecutorIntegrationTest extends AbstractWorkerExecutorIntegrationTes | |||
| assertDifferentDaemonsWereUsed("runInDaemon", "startNewDaemon") | |||
| } | |||
|
|
|||
| @Issue("https://github.com/gradle/gradle/issues/10411") | |||
| def "does not leak project state across multiple builds"() { | |||
There was a problem hiding this comment.
I wonder if this wouldn't be better as a soak test and have it run like 20 builds or something. The name of the test bothers me a little bit - it doesn't actually prove that it doesn't leak state - only that you don't get an OOM after 3 builds. I'm not sure that I have a better suggestion, but running more iterations would make me more comfortable with it.
| @@ -217,6 +217,41 @@ class WorkerExecutorLegacyApiIntegrationTest extends AbstractIntegrationSpec { | |||
| isolationMode << ISOLATION_MODES | |||
| } | |||
|
|
|||
| @Issue("https://github.com/gradle/gradle/issues/10411") | |||
| def "does not leak project state across multiple builds"() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10411
Context
Contributor Checklist
<subproject>/src/integTest) to verify changes from a user perspective<subproject>/src/test) to verify logic./gradlew <changed-subproject>:checkGradle Core Team Checklist