Polishing of JaCoCo coverage validation changes #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 3, 2017 15:16
bmuschko
added
a:chore
added 2 commits
January 4, 2017 16:12
We can fully rely on Groovy SAM here.
big-guy
requested changes
Jan 5, 2017
There was a problem hiding this comment.
Thanks @bmuschko.
JacocoCoverageVerificationshould be added to the DSL guide- Release notes misspell the new task (
JacocoCoverageVerification) - In
JacocoReportBase, it probably makes sense to inline thefileExistsSpecin the two places it's used instead of making it part of the public API. - WRT documenting the setters, we should. The other classes weren't documented because they used to be Groovy and the documentation was only on the property.
- WRT our conversation on Slack, if we make the verification check a part of the
checktask, we need to make the verification task behave in an incremental way (only run when something has changed). - It would be really nice if the failure message from JaCoCo was in the failure at the end of the build.
added 4 commits
January 10, 2017 14:40
Throws any failure as GradleException instead of letting Ant take charge of it.
big-guy
reviewed
Jan 11, 2017
| @Override | ||
| protected void configureReport(final GroovyObjectSupport antBuilder, final JacocoViolationRulesContainer violationRules) { | ||
| if (!violationRules.getRules().isEmpty()) { | ||
| Map<String, Object> checkArgs = ImmutableMap.<String, Object>of("failonviolation", !violationRules.isFailOnViolation()); | ||
| Map<String, Object> checkArgs = ImmutableMap.<String, Object>of("failonviolation", violationRules.isFailOnViolation(), "violationsproperty", VIOLATIONS_ANT_PROPERTY); |
There was a problem hiding this comment.
Couldn't this always be 'false' and then we wouldn't have to catch the exception above?
There was a problem hiding this comment.
An exception would still be thrown from Ant if you provide invalid validation rules and set failonviolation = false. For more info see test case JacocoPluginCoverageVerificationIntegrationTest.Ant task reports error for unknown field value.
big-guy
approved these changes
Jan 11, 2017
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review comments made by @big-guy after merging the pull request #983.