Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kotlin DSL accessor for android.kotlinOptions #11191

Merged
merged 1 commit into from Oct 30, 2019
Merged

Fix Kotlin DSL accessor for android.kotlinOptions #11191

merged 1 commit into from Oct 30, 2019

Conversation

bamboo
Copy link
Member

@bamboo bamboo commented Oct 30, 2019

And introduce a stricter accessor type precedence order.

The accessor type is the first public Kotlin type found in the given extension
type hierarchy considering all the types in the following order:

  • the extension type itsef
  • its superclasses excluding java.lang.Object
  • all supported interfaces ordered by:
    • subtyping first:
      subtypes before supertypes
    • where it's found in the class hierarchy:
      subclass interfaces before superclass interfaces

Fixes #11083

@bamboo
Fix Kotlin DSL accessor for android.kotlinOptions
70a5fd2 
And introduce a stricter accessor type precedence order.

The accessor type is the first public Kotlin type found in the given extension
type hierarchy considering all the types in the following order:
* the extension type itsef
* its superclasses excluding `java.lang.Object`
* all supported interfaces ordered by:
  - subtyping first:
      subtypes before supertypes
  - where it's found in the class hierarchy:
      subclass interfaces before superclass interfaces

Fixes #11083
@bamboo bamboo added this to the 5.6.4 milestone Oct 30, 2019
@bamboo bamboo self-assigned this Oct 30, 2019
@bamboo bamboo requested a review from eskatos October 30, 2019 22:24
@bamboo bamboo merged commit 7ee1ee9 into release-5.6 Oct 30, 2019
@bamboo bamboo mentioned this pull request Oct 30, 2019
Closed
@bamboo bamboo deleted the bamboo/release-5.6/android-kotlin-options branch November 19, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskatos eskatos Awaiting requested review from eskatos

Assignees

@bamboo bamboo

Labels
a:bug in:kotlin-dsl
Projects
None yet
Milestone
5.6.4
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bamboo