Allow publication artifacts to be defined as files through providers #11329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to work in Gradle 5.5 (see #11054). The combination of #9467 and #6775 broke this. A builtBy dependency is added if the artifact is a TaskDependencyContainer, which all Providers are (#9467). This dependency was silently doing nothing in case of a plain File/String. This became an error (#6775) because a File/String is nothing that can be resolved to a task. We now only add a builtBy dependency, if the provider value or content is actually produced by a task.
melix
approved these changes
Nov 12, 2019
adammurdoch
reviewed
Nov 13, 2019
.../integTest/groovy/org/gradle/api/publish/ivy/IvyPublishArtifactCustomizationIntegTest.groovy
Show resolved
Hide resolved
...main/java/org/gradle/api/publish/ivy/internal/artifact/IvyArtifactNotationParserFactory.java
Show resolved
Hide resolved
jjohannes
added a commit
that referenced
this pull request
Nov 13, 2019
*Updated solution based on feedback to #11329* This used to work in Gradle 5.5 (see #11054). The combination of #9467 and #6775 broke this. A builtBy dependency is added if the artifact is a TaskDependencyContainer, which all Providers are (#9467). This dependency was silently doing nothing in case of a plain File/String. This became an error (#6775) because a File/String is nothing that can be resolved to a task. We now only add a builtBy dependency, if the provider value or content is actually produced by a task.
|
Update based on feedback: 62cfd99 |
jjohannes
added a commit
that referenced
this pull request
Nov 13, 2019
*Updated solution based on feedback to #11329* This used to work in Gradle 5.5 (see #11054). The combination of #9467 and #6775 broke this. A builtBy dependency is added if the artifact is a TaskDependencyContainer, which all Providers are (#9467). This dependency was silently doing nothing in case of a plain File/String. This became an error (#6775) because a File/String is nothing that can be resolved to a task. We now only add a builtBy dependency, if the provider value or content is actually produced by a task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to work in Gradle 5.5 (see #11054).
The combination of #9467 and #6775 broke this.
A builtBy dependency is added if the artifact is a TaskDependencyContainer,
which all Providers are (#9467). This dependency was silently doing
nothing in case of a plain File/String. This became an error (#6775)
because a File/String is nothing that can be resolved to a task.
We now only add a builtBy dependency, if the provider value or content is
actually produced by a task.