Fix AndroidJavaCompile not detecting incremental changes #11331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfs
changed the title
The method `fun getSources(): FileTree` does not override the method `protected FileCollection getSources()`, since the AGP plugin 3.5.1 has not been compiled against Gradle 6.0, and therefore the necessary bridge method is not generated.
wolfs
force-pushed
the
wolfs/java-compile/fix-android
branch
from
d11af34
to
2e9e6f8
Compare
|
@lptr Please take a look! |
|
Can we update one of the Android smoke tests to do an incremental compile too? |
|
@big-guy We can and we should. |
lptr
approved these changes
Nov 13, 2019
The breaking change actually fixes the problem.
|
I'll do the smoke test(s) on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
fun getSources(): FileTreedoes not override the methodprotected FileCollection getSources(), since the AGP plugin 3.5.1 hasnot been compiled against Gradle 6.0, and therefore the necessary bridge
method is not generated.
Fixes #11330.